chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm - Issue 2040143006: Implement the Sync promo in the password bubble on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Issue 2040143006: Implement the Sync promo in the password bubble on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

index 49a5b9dc642c242bf7498e8f58ea74bd087390d3..696e92eac5c3f35ff725541ed02be47fbf95b623 100644

--- a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

@@ -22,8 +22,13 @@

- (void)onSaveClicked:(id)sender {

ManagePasswordsBubbleModel* model = self.model;

- if (model)

+ if (model) {

model->OnSaveClicked();

+ if (model->ReplaceToShowSignInPromoIfNeeded()) {

+ [self.delegate refreshBubble];

+ return;

+ }

[self.delegate viewShouldDismiss];

}