Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7524)

Unified Diff: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm

Issue 2040143006: Implement the Sync promo in the password bubble on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
index 61a8f2dbc85867c210509a3f9946f208e5f733c4..f35139f75724b2db7f948c8f40b3bf07aa3d0027 100644
--- a/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm
@@ -21,28 +21,19 @@ namespace {
class SavePendingPasswordViewControllerTest
: public ManagePasswordsControllerTest {
public:
- SavePendingPasswordViewControllerTest() {}
-
- void SetUp() override {
- ManagePasswordsControllerTest::SetUp();
- delegate_.reset([[ContentViewDelegateMock alloc] init]);
+ void SetUpSavePendingState(bool empty_username) {
+ ManagePasswordsControllerTest::SetUpSavePendingState(empty_username);
+ controller_.reset([[SavePendingPasswordViewController alloc]
+ initWithDelegate:delegate()]);
+ [controller_ view];
}
- ContentViewDelegateMock* delegate() { return delegate_.get(); }
-
SavePendingPasswordViewController* controller() {
- if (!controller_) {
- [delegate() setModel:GetModelAndCreateIfNull()];
- controller_.reset([[SavePendingPasswordViewController alloc]
- initWithDelegate:delegate()]);
- [controller_ view];
- }
return controller_.get();
}
private:
base::scoped_nsobject<SavePendingPasswordViewController> controller_;
- base::scoped_nsobject<ContentViewDelegateMock> delegate_;
};
TEST_F(SavePendingPasswordViewControllerTest,
@@ -92,7 +83,6 @@ TEST_F(SavePendingPasswordViewControllerTest, CloseBubbleAndHandleClick) {
SetUpSavePendingState(false);
EXPECT_CALL(*ui_controller(), SavePassword()).Times(0);
EXPECT_CALL(*ui_controller(), NeverSavePassword()).Times(0);
- [controller() bubbleWillDisappear];
[delegate() setModel:nil];
[controller().neverButton performClick:nil];
[controller().saveButton performClick:nil];

Powered by Google App Engine
This is Rietveld 408576698