Replicating can_open_windows layout tests runtime flag across OOPIFs.

Replicating can_open_windows layout tests runtime flag across OOPIFs.

BUG=617288, 587175
Committed: https://crrev.com/f1b569284f471793c36353fd9dce34139638472f
Cr-Commit-Position: refs/heads/master@{#398362}

[Łukasz Anforowicz, 2016-06-06 21:17:14]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-06-06 21:17:14]

jochen@, could you please take a look?

https://codereview.chromium.org/2039313002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/navigation/resources/no-referrer-helper.php
(right):

https://codereview.chromium.org/2039313002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/navigation/resources/no-referrer-helper.php:22:
if (consoleWindow && consoleWindow.log) {
The new condition is necessary to check if consoleWindow 1) opened a new window
or 2) found the window named "consoleWindow".
Before this CL, can_open_windows wouldn't propagate and window.open would always
return null, but after this CL window.open started to create a new window
(rather than finding an already existing window - see https://crbug.com/617755)
and throwing an exception when trying to call consoleWindow.log (which doesn't
exist in the new window).

[Łukasz Anforowicz, 2016-06-06 21:33:21]

Description was changed from

==========
Replicating can_open_windows layout tests runtime flag across OOPIFs.

BUG=617288
==========

to

==========
Replicating can_open_windows layout tests runtime flag across OOPIFs.

BUG=617288, 587175
==========

[jochen (gone - plz use gerrit), 2016-06-07 15:06:55]

lgtm

[Łukasz Anforowicz, 2016-06-07 16:02:14]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039313002/20001

[commit-bot: I haz the power, 2016-06-07 16:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:23:06]

Try jobs failed on following builders:
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Łukasz Anforowicz, 2016-06-07 16:26:58]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:32:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039313002/20001

[commit-bot: I haz the power, 2016-06-07 18:00:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 18:00:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2016-06-07 18:24:15]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-06-07 18:24:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039313002/20001

[commit-bot: I haz the power, 2016-06-07 19:08:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 19:10:55]

Description was changed from

==========
Replicating can_open_windows layout tests runtime flag across OOPIFs.

BUG=617288, 587175
==========

to

==========
Replicating can_open_windows layout tests runtime flag across OOPIFs.

BUG=617288, 587175

Committed: https://crrev.com/f1b569284f471793c36353fd9dce34139638472f
Cr-Commit-Position: refs/heads/master@{#398362}
==========

[commit-bot: I haz the power, 2016-06-07 19:10:56]

Patchset 2 (id:??) landed as
https://crrev.com/f1b569284f471793c36353fd9dce34139638472f
Cr-Commit-Position: refs/heads/master@{#398362}