components/test_runner/test_runner.h - Issue 2039313002: Replicating can_open_windows layout tests runtime flag across OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.h

Issue 2039313002: Replicating can_open_windows layout tests runtime flag across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Insulating no-referrer-helper.php from the changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/layout_test_runtime_flags.cc ('k') | components/test_runner/test_runner.cc » ('j') | third_party/WebKit/LayoutTests/http/tests/navigation/resources/no-referrer-helper.php » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_runner.h

diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h

index fe056e1caee1bc60ed00aefe542235cb9a1b8dd0..197f167fbe2e54f92535975d34aac263ef0d798d 100644

--- a/components/test_runner/test_runner.h

+++ b/components/test_runner/test_runner.h

@@ -574,11 +574,6 @@ class TestRunner : public WebTestRunner {

// is invoked.

bool dump_create_view_;

- // If true, new windows can be opened via javascript or by plugins. By

- // default, set to false and can be toggled to true using

- // setCanOpenWindows().

- bool can_open_windows_;

// If true, the test_shell will dump all changes to window.status.

bool dump_window_status_changes_;