components/test_runner/layout_test_runtime_flags.h - Issue 2039313002: Replicating can_open_windows layout tests runtime flag across OOPIFs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/layout_test_runtime_flags.h

Issue 2039313002: Replicating can_open_windows layout tests runtime flag across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Insulating no-referrer-helper.php from the changes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/test_runner/layout_test_runtime_flags.cc » ('j') | third_party/WebKit/LayoutTests/http/tests/navigation/resources/no-referrer-helper.php » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/layout_test_runtime_flags.h

diff --git a/components/test_runner/layout_test_runtime_flags.h b/components/test_runner/layout_test_runtime_flags.h

index 32f836c50bf8c4f2062db382e7dfb55348baf36c..080bc9e58d84df463168301ca36423c299f35878 100644

--- a/components/test_runner/layout_test_runtime_flags.h

+++ b/components/test_runner/layout_test_runtime_flags.h

@@ -165,6 +165,11 @@ class TEST_RUNNER_EXPORT LayoutTestRuntimeFlags {

// one renderer and an OOPIF in another renderer).

DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(have_top_loading_frame)

+ // If true, new windows can be opened via javascript or by plugins. By

+ // default, set to false and can be toggled to true using

+ // setCanOpenWindows().

+ DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(can_open_windows)

#undef DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG

#undef DEFINE_STRING_LAYOUT_TEST_RUNTIME_FLAG