Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: components/test_runner/test_runner.cc

Issue 2039313002: Replicating can_open_windows layout tests runtime flag across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Insulating no-referrer-helper.php from the changes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 7d1b8334f72e0d224f341e6f0ee84fa75c32c41d..d23078b3a6439c5e52c7471e63ced86764de9968 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -1605,7 +1605,6 @@ void TestRunner::Reset() {
dump_as_audio_ = false;
dump_create_view_ = false;
- can_open_windows_ = false;
dump_window_status_changes_ = false;
dump_spell_check_callbacks_ = false;
dump_back_forward_list_ = false;
@@ -1782,7 +1781,7 @@ bool TestRunner::shouldDumpCreateView() const {
}
bool TestRunner::canOpenWindows() const {
- return can_open_windows_;
+ return layout_test_runtime_flags_.can_open_windows();
}
bool TestRunner::shouldDumpResourceLoadCallbacks() const {
@@ -2433,7 +2432,8 @@ void TestRunner::DumpCreateView() {
}
void TestRunner::SetCanOpenWindows() {
- can_open_windows_ = true;
+ layout_test_runtime_flags_.set_can_open_windows(true);
+ OnLayoutTestRuntimeFlagsChanged();
}
void TestRunner::DumpResourceLoadCallbacks() {

Powered by Google App Engine
This is Rietveld 408576698