Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2036893002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/33f3dc9fd20d067f768c76b215441d0a19793486 Cr-Commit-Position: refs/heads/master@{#397591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M content/browser/webui/web_ui_message_handler_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/font_list_pango.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:19:20 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 6 months ago (2016-06-02 22:35:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036893002/1
4 years, 6 months ago (2016-06-02 22:50:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 02:38:35 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:41:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33f3dc9fd20d067f768c76b215441d0a19793486
Cr-Commit-Position: refs/heads/master@{#397591}

Powered by Google App Engine
This is Rietveld 408576698