Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content

content/browser/webui/web_ui_message_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/web_ui_message_handler.h"
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 TEST(WebUIMessageHandlerTest, ExtractIntegerValue) {
   base::ListValue list;
   int value, zero_value = 0, neg_value = -1234, pos_value = 1234;
   base::string16 zero_string(base::UTF8ToUTF16("0"));
   base::string16 neg_string(base::UTF8ToUTF16("-1234"));
   base::string16 pos_string(base::UTF8ToUTF16("1234"));
 
-  list.Append(new base::FundamentalValue(zero_value));
+  list.AppendInteger(zero_value);
   EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
   EXPECT_EQ(value, zero_value);
   list.Clear();
 
-  list.Append(new base::FundamentalValue(neg_value));
+  list.AppendInteger(neg_value);
   EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
   EXPECT_EQ(value, neg_value);
   list.Clear();
 
-  list.Append(new base::FundamentalValue(pos_value));
+  list.AppendInteger(pos_value);
   EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
   EXPECT_EQ(value, pos_value);
   list.Clear();
 
-  list.Append(new base::StringValue(zero_string));
+  list.AppendString(zero_string);
   EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
   EXPECT_EQ(value, zero_value);
   list.Clear();
 
-  list.Append(new base::StringValue(neg_string));
+  list.AppendString(neg_string);
   EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
   EXPECT_EQ(value, neg_value);
   list.Clear();
 
-  list.Append(new base::StringValue(pos_string));
+  list.AppendString(pos_string);
   EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
   EXPECT_EQ(value, pos_value);
 }
 
 TEST(WebUIMessageHandlerTest, ExtractDoubleValue) {
   base::ListValue list;
   double value, zero_value = 0.0, neg_value = -1234.5, pos_value = 1234.5;
   base::string16 zero_string(base::UTF8ToUTF16("0"));
   base::string16 neg_string(base::UTF8ToUTF16("-1234.5"));
   base::string16 pos_string(base::UTF8ToUTF16("1234.5"));
 
-  list.Append(new base::FundamentalValue(zero_value));
+  list.AppendDouble(zero_value);
   EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
   EXPECT_DOUBLE_EQ(value, zero_value);
   list.Clear();
 
-  list.Append(new base::FundamentalValue(neg_value));
+  list.AppendDouble(neg_value);
   EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
   EXPECT_DOUBLE_EQ(value, neg_value);
   list.Clear();
 
-  list.Append(new base::FundamentalValue(pos_value));
+  list.AppendDouble(pos_value);
   EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
   EXPECT_DOUBLE_EQ(value, pos_value);
   list.Clear();
 
-  list.Append(new base::StringValue(zero_string));
+  list.AppendString(zero_string);
   EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
   EXPECT_DOUBLE_EQ(value, zero_value);
   list.Clear();
 
-  list.Append(new base::StringValue(neg_string));
+  list.AppendString(neg_string);
   EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
   EXPECT_DOUBLE_EQ(value, neg_value);
   list.Clear();
 
-  list.Append(new base::StringValue(pos_string));
+  list.AppendString(pos_string);
   EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
   EXPECT_DOUBLE_EQ(value, pos_value);
 }
 
 TEST(WebUIMessageHandlerTest, ExtractStringValue) {
   base::ListValue list;
   base::string16 in_string(base::UTF8ToUTF16(
       "The facts, though interesting, are irrelevant."));
-  list.Append(new base::StringValue(in_string));
+  list.AppendString(in_string);
   base::string16 out_string = WebUIMessageHandler::ExtractStringValue(&list);
   EXPECT_EQ(in_string, out_string);
 }
 
 }  // namespace content