Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/common/font_list_pango.cc

Issue 2036893002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/font_list_pango.cc
diff --git a/content/common/font_list_pango.cc b/content/common/font_list_pango.cc
index d64c9033a0c03384ecd91dfe1deceda8581502a2..938d0597c5c5bc28d633cb1f4f61de49046b0ca6 100644
--- a/content/common/font_list_pango.cc
+++ b/content/common/font_list_pango.cc
@@ -31,8 +31,8 @@ std::unique_ptr<base::ListValue> GetFontList_SlowBlocking() {
for (std::set<std::string>::const_iterator iter = sorted_families.begin();
iter != sorted_families.end(); ++iter) {
base::ListValue* font_item = new base::ListValue();
- font_item->Append(new base::StringValue(*iter));
- font_item->Append(new base::StringValue(*iter)); // localized name.
+ font_item->AppendString(*iter);
+ font_item->AppendString(*iter); // localized name.
// TODO(yusukes): Support localized family names.
font_list->Append(font_item);
}
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698