Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: content/child/v8_value_converter_impl_unittest.cc

Issue 2036893002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/webui/web_ui_message_handler_unittest.cc ('k') | content/common/font_list_pango.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl_unittest.cc
diff --git a/content/child/v8_value_converter_impl_unittest.cc b/content/child/v8_value_converter_impl_unittest.cc
index 43b654df1fcbd80b862fb4b4cb6799a065b4bdf5..78b377a3a6df354a11b6819a39591faef0b35b14 100644
--- a/content/child/v8_value_converter_impl_unittest.cc
+++ b/content/child/v8_value_converter_impl_unittest.cc
@@ -568,7 +568,7 @@ TEST_F(V8ValueConverterImplTest, ArrayPrototypeSetter) {
// Try again, using an array without the index.
base::ListValue one_item_list;
- one_item_list.Append(new base::FundamentalValue(123456));
+ one_item_list.AppendInteger(123456);
v8::Local<v8::Array> converted2 =
converter.ToV8Value(&one_item_list, context).As<v8::Array>();
EXPECT_FALSE(converted2.IsEmpty());
« no previous file with comments | « content/browser/webui/web_ui_message_handler_unittest.cc ('k') | content/common/font_list_pango.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698