Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 2035633002: V8: Explicitly define presence of valgrind on relevant builder (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Explicitly define presence of valgrind on relevant builder BUG=609107 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5f51f767b47ddcec076ade3a76c24599d638ca16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/v8/chromium_config.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL
4 years, 6 months ago (2016-06-02 07:37:35 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-02 07:39:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035633002/1
4 years, 6 months ago (2016-06-02 07:51:07 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 07:54:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/5f51f767b47ddcec076a...

Powered by Google App Engine
This is Rietveld 408576698