Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json

Issue 2035633002: V8: Explicitly define presence of valgrind on relevant builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/v8/chromium_config.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
index 877c3f9d03746304582565b8d1350624c4c12625..363ec6de03f1a2ce4276ac0f2b2a8d52b2f89994 100644
--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
@@ -87,7 +87,7 @@
"cwd": "[SLAVE_BUILD]/v8",
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
- "GYP_DEFINES": "clang=1 gomadir='[BUILD]/goma' jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "clang=1 gomadir='[BUILD]/goma' has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja",
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
@@ -306,7 +306,7 @@
"builder_name": "V8 Fuzzer",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",
@@ -330,7 +330,7 @@
"builder_name": "V8 Linux64 - debug",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",
@@ -354,7 +354,7 @@
"builder_name": "V8 Linux64 - debug - avx2",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",
@@ -378,7 +378,7 @@
"builder_name": "V8 Linux64 - debug - greedy allocator",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",
« no previous file with comments | « scripts/slave/recipe_modules/v8/chromium_config.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698