scripts/slave/recipe_modules/v8/chromium_config.py - Issue 2035633002: V8: Explicitly define presence of valgrind on relevant builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/chromium_config.py

Issue 2035633002: V8: Explicitly define presence of valgrind on relevant builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/v8/builders.py ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/v8/chromium_config.py

diff --git a/scripts/slave/recipe_modules/v8/chromium_config.py b/scripts/slave/recipe_modules/v8/chromium_config.py

index e91588560ec3376328ade72cfebe4890fc141dac..681c960ee373bce9e7a4bcabb3b13e524598e94d 100644

--- a/scripts/slave/recipe_modules/v8/chromium_config.py

+++ b/scripts/slave/recipe_modules/v8/chromium_config.py

@@ -92,6 +92,11 @@ def gcmole(c):

@CONFIG_CTX(includes=['v8'])

+def has_valgrind(c):

+ c.gyp_env.GYP_DEFINES['has_valgrind'] = 1

+@CONFIG_CTX(includes=['v8'])

def coverage(c):

c.gyp_env.GYP_DEFINES['coverage'] = 1