scripts/slave/recipe_modules/v8/builders.py - Issue 2035633002: V8: Explicitly define presence of valgrind on relevant builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/builders.py

Issue 2035633002: V8: Explicitly define presence of valgrind on relevant builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/v8/builders.py

diff --git a/scripts/slave/recipe_modules/v8/builders.py b/scripts/slave/recipe_modules/v8/builders.py

index c26be3a4ab0eadd75fefde9e7f3fff91cd19cb1a..fe91861e957ca1e6d3f17fc2b1b1b2dcf182c9e8 100644

--- a/scripts/slave/recipe_modules/v8/builders.py

+++ b/scripts/slave/recipe_modules/v8/builders.py

@@ -364,7 +364,8 @@ BUILDERS = {

'V8 Linux64 - debug builder': {

'gclient_apply_config': ['v8_valgrind'],

- 'chromium_apply_config': ['clang', 'v8_ninja', 'goma', 'jsfunfuzz'],

+ 'chromium_apply_config': [

+ 'clang', 'v8_ninja', 'goma', 'jsfunfuzz', 'has_valgrind'],

'v8_config_kwargs': {

'BUILD_CONFIG': 'Debug',

'TARGET_BITS': 64,

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/chromium_config.py » ('j') | no next file with comments »