third_party/WebKit/Source/core/html/forms/InputType.cpp - Issue 2035263002: Extract SourceLocation for ConsoleMessages on call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.cpp

Issue 2035263002: Extract SourceLocation for ConsoleMessages on call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2037593004

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp ('k') | third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/InputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/InputType.cpp b/third_party/WebKit/Source/core/html/forms/InputType.cpp

index 5e88d20f06163d16beb9455f7b7881d317176e4a..7f7779b13f289f56573e3bb32ae470bef9cf4949 100644

--- a/third_party/WebKit/Source/core/html/forms/InputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/InputType.cpp

@@ -29,6 +29,7 @@

#include "bindings/core/v8/ExceptionMessages.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/SourceLocation.h"

#include "core/InputTypeNames.h"

#include "core/dom/AXObjectCache.h"

#include "core/dom/ExceptionCode.h"

@@ -940,7 +941,8 @@ StepRange InputType::createStepRange(AnyStepHandling anyStepHandling, const Deci

void InputType::addWarningToConsole(const char* messageFormat, const String& value) const

{

element().document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, WarningMessageLevel,

- String::format(messageFormat, JSONValue::quoteString(value).utf8().data())));

+ String::format(messageFormat, JSONValue::quoteString(value).utf8().data()),

+ SourceLocation::capture(&element().document())));

}

} // namespace blink