Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

Issue 2035263002: Extract SourceLocation for ConsoleMessages on call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2037593004
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/MixedContentChecker.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2007 Rob Buis <buis@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 */ 20 */
21 21
22 #include "core/svg/SVGDocumentExtensions.h" 22 #include "core/svg/SVGDocumentExtensions.h"
23 23
24 #include "bindings/core/v8/SourceLocation.h"
24 #include "core/dom/Document.h" 25 #include "core/dom/Document.h"
25 #include "core/inspector/ConsoleMessage.h" 26 #include "core/inspector/ConsoleMessage.h"
26 #include "core/layout/svg/SVGResourcesCache.h" 27 #include "core/layout/svg/SVGResourcesCache.h"
27 #include "core/svg/SVGSVGElement.h" 28 #include "core/svg/SVGSVGElement.h"
28 #include "core/svg/animation/SMILTimeContainer.h" 29 #include "core/svg/animation/SMILTimeContainer.h"
29 #include "wtf/TemporaryChange.h" 30 #include "wtf/TemporaryChange.h"
30 #include "wtf/text/AtomicString.h" 31 #include "wtf/text/AtomicString.h"
31 32
32 namespace blink { 33 namespace blink {
33 34
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 continue; 144 continue;
144 145
145 // don't dispatch the load event document is not wellformed (for XML/sta ndalone svg) 146 // don't dispatch the load event document is not wellformed (for XML/sta ndalone svg)
146 if (outerSVG->document().wellFormed() || !outerSVG->document().isSVGDocu ment()) 147 if (outerSVG->document().wellFormed() || !outerSVG->document().isSVGDocu ment())
147 outerSVG->sendSVGLoadEventIfPossible(); 148 outerSVG->sendSVGLoadEventIfPossible();
148 } 149 }
149 } 150 }
150 151
151 void SVGDocumentExtensions::reportError(const String& message) 152 void SVGDocumentExtensions::reportError(const String& message)
152 { 153 {
153 ConsoleMessage* consoleMessage = ConsoleMessage::create(RenderingMessageSour ce, ErrorMessageLevel, "Error: " + message); 154 ConsoleMessage* consoleMessage = ConsoleMessage::create(RenderingMessageSour ce, ErrorMessageLevel, "Error: " + message, SourceLocation::capture(m_document) );
154 m_document->addConsoleMessage(consoleMessage); 155 m_document->addConsoleMessage(consoleMessage);
155 } 156 }
156 157
157 void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element) 158 void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element)
158 { 159 {
159 ASSERT(element); 160 ASSERT(element);
160 ASSERT(element->inShadowIncludingDocument()); 161 ASSERT(element->inShadowIncludingDocument());
161 162
162 if (id.isEmpty()) 163 if (id.isEmpty())
163 return; 164 return;
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 { 362 {
362 visitor->trace(m_document); 363 visitor->trace(m_document);
363 visitor->trace(m_timeContainers); 364 visitor->trace(m_timeContainers);
364 visitor->trace(m_webAnimationsPendingSVGElements); 365 visitor->trace(m_webAnimationsPendingSVGElements);
365 visitor->trace(m_relativeLengthSVGRoots); 366 visitor->trace(m_relativeLengthSVGRoots);
366 visitor->trace(m_pendingResources); 367 visitor->trace(m_pendingResources);
367 visitor->trace(m_pendingResourcesForRemoval); 368 visitor->trace(m_pendingResourcesForRemoval);
368 } 369 }
369 370
370 } // namespace blink 371 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/MixedContentChecker.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698