Rename InkDropHover to InkDropHighlight

Rename InkDropHover to InkDropHighlight

Most uses of "hover" become "highlight", but SetHovered still refers to
the logical state of mouse hover so that remains unaltered.

BUG=none

Committed: https://crrev.com/3836df28ab02649fc41b5ed3950f0c49db2cb451
Cr-Commit-Position: refs/heads/master@{#397843}

[Evan Stade, 2016-06-02 23:53:43]

estade@chromium.org changed reviewers:
+ bruthig@chromium.org, sky@chromium.org

[bruthig, 2016-06-03 02:50:46]

A few minor nits, otherwise LGTM.
Thanks!

https://codereview.chromium.org/2034963002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:20: #include
"ui/views/animation/ink_drop_highlight.h"
Is this needed?

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_highlight.h (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_highlight.h:34: // visual feedback on ui::Views for
mouse highlight states.
nit: Can you update the comment to not be mouse specific?

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_host.h (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host.h:44: // Creates and returns the effect used
for hover.
Replace 'hover' with 'highlight' or 'hover/focus'.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl.cc:195: if (is_hovered_)
This should probably be 'if (is_hovered_ || is focused_)'

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl.h (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl.h:96: // an
Join lines 96/97.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl_unittest.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl_unittest.cc:126: TEST_F(InkDropImplTest,
HoveredStateNotVisibleOrFadingInAfterAnimateToState) {
Replace 'Hovered' with 'Highlight'.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl_unittest.cc:138: // returns null for the hover.
Replace 'hover' with 'highlight'.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/test...
File ui/views/animation/test/test_ink_drop_host.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/test...
ui/views/animation/test/test_ink_drop_host.cc:101:
std::unique_ptr<InkDropHighlight> hover;
Rename 'hover' as 'highlight'.

[Evan Stade, 2016-06-03 03:01:41]

https://codereview.chromium.org/2034963002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:20: #include
"ui/views/animation/ink_drop_highlight.h"
On 2016/06/03 02:50:45, bruthig wrote:
> Is this needed?

Done.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_highlight.h (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_highlight.h:34: // visual feedback on ui::Views for
mouse highlight states.
On 2016/06/03 02:50:46, bruthig wrote:
> nit: Can you update the comment to not be mouse specific?

Done.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_host.h (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host.h:44: // Creates and returns the effect used
for hover.
On 2016/06/03 02:50:46, bruthig wrote:
> Replace 'hover' with 'highlight' or 'hover/focus'. 

Done.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl.cc:195: if (is_hovered_)
On 2016/06/03 02:50:46, bruthig wrote:
> This should probably be 'if (is_hovered_ || is focused_)'

I'm a bit squeamish about making functional changes in this patchset.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl.h (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl.h:96: // an
On 2016/06/03 02:50:46, bruthig wrote:
> Join lines 96/97.

Done.

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl_unittest.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl_unittest.cc:138: // returns null for the hover.
On 2016/06/03 02:50:46, bruthig wrote:
> Replace 'hover' with 'highlight'.

Done.

[bruthig, 2016-06-03 03:04:37]

slgtm

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_impl.cc (right):

https://codereview.chromium.org/2034963002/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_impl.cc:195: if (is_hovered_)
On 2016/06/03 03:01:41, Evan Stade wrote:
> On 2016/06/03 02:50:46, bruthig wrote:
> > This should probably be 'if (is_hovered_ || is focused_)'
> 
> I'm a bit squeamish about making functional changes in this patchset.

Acknowledged.

[sky, 2016-06-03 17:03:00]

LGTM

[Evan Stade, 2016-06-03 21:45:43]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-06-03 21:45:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
bruthig@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2034963002/#ps60001
(title: "remove dependencyh on other patch")

[commit-bot: I haz the power, 2016-06-03 21:46:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034963002/60001

[commit-bot: I haz the power, 2016-06-03 21:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 21:52:35]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-06-03 22:03:07]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-06-03 22:03:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2034963002/#ps80001
(title: "fix gyp file")

[commit-bot: I haz the power, 2016-06-03 22:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034963002/80001

[commit-bot: I haz the power, 2016-06-03 23:38:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-03 23:39:57]

Description was changed from

==========
Rename InkDropHover to InkDropHighlight

Most uses of "hover" become "highlight", but SetHovered still refers to
the logical state of mouse hover so that remains unaltered.

BUG=none
==========

to

==========
Rename InkDropHover to InkDropHighlight

Most uses of "hover" become "highlight", but SetHovered still refers to
the logical state of mouse hover so that remains unaltered.

BUG=none

Committed: https://crrev.com/3836df28ab02649fc41b5ed3950f0c49db2cb451
Cr-Commit-Position: refs/heads/master@{#397843}
==========

[commit-bot: I haz the power, 2016-06-03 23:39:58]

Patchset 5 (id:??) landed as
https://crrev.com/3836df28ab02649fc41b5ed3950f0c49db2cb451
Cr-Commit-Position: refs/heads/master@{#397843}