chrome/browser/ui/views/toolbar/toolbar_action_view.cc - Issue 2034963002: Rename InkDropHover to InkDropHighlight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2034963002: Rename InkDropHover to InkDropHighlight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gyp file Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

index bfb6bf7eb66e3e8c4d657f70ee4238b038b540a7..ce5fcaa733f89c12b516e4cb6cb5b0c2701ef05e 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

@@ -117,9 +117,9 @@ SkColor ToolbarActionView::GetInkDropBaseColor() const {

ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON);

}

-bool ToolbarActionView::ShouldShowInkDropHover() const {

+bool ToolbarActionView::ShouldShowInkDropHighlight() const {

return !delegate_->ShownInsideMenu() &&

- views::MenuButton::ShouldShowInkDropHover();

+ views::MenuButton::ShouldShowInkDropHighlight();

}

content::WebContents* ToolbarActionView::GetCurrentWebContents() const {