Chromium Code Reviews Chromium Code Reviews
Issue
203443010:
DevTools: [JsDocValidator] Fix checking of receivers specified as arguments (Closed)
DescriptionDevTools: [JsDocValidator] Fix checking of receivers specified as arguments
r169450 has resulted in multiple failures of existing code where functions
annotated with @this are passed as arguments along with their receivers.
The cases include:
- Array.prototype.forEach and other iteration-with-callback methods.
- RemoteObject.prototype.callFunction[JSON], whose functionDeclaration
can be evaluated on any Object (but expect a certain type thereof).
- WebInspector.Object.prototype.{add,remove}EventListener, which accepts
the callback receiver as its third argument.
This patch introduces receiver specification detection in these cases,
or resorts to IGNORE in ambiguous situations.
R=aandrey, sergeyv, vsevik
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169549
Patch Set 1 #Patch Set 2 : Use @suppressReceiverCheck annotation for whitelisted callbacks with @this but with no receiver #
Total comments: 4
Patch Set 3 : Comments addressed #
Total comments: 2
Patch Set 4 : Add a suppression hint message #Messages
Total messages: 12 (0 generated)
|
