Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 203443010: DevTools: [JsDocValidator] Fix checking of receivers specified as arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a suppression hint message Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends 1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends
2 * @extends {Base} 2 * @extends {Base}
3 ^ 3 ^
4 4
5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor 5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor
6 DerivedNoProto = function() {} 6 DerivedNoProto = function() {}
7 ^ 7 ^
8 8
9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:16: ERROR - Type DerivedBadProto extends Base but does not properly invoke its constructor 9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:16: ERROR - Type DerivedBadProto extends Base but does not properly invoke its constructor
10 DerivedBadProto = function() {} 10 DerivedBadProto = function() {}
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 ^ 227 ^
228 228
229 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:224: ERROR - Receiver specified for a func tion not annotated with @this 229 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:224: ERROR - Receiver specified for a func tion not annotated with @this
230 callbackNoThis.apply(this); // ERROR - Function has no @this annotation. 230 callbackNoThis.apply(this); // ERROR - Function has no @this annotation.
231 ^ 231 ^
232 232
233 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:225: ERROR - Receiver specified for a func tion not annotated with @this 233 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:225: ERROR - Receiver specified for a func tion not annotated with @this
234 callbackNoThis.bind(this); // ERROR - Function has no @this annotation. 234 callbackNoThis.bind(this); // ERROR - Function has no @this annotation.
235 ^ 235 ^
236 236
237 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:227: ERROR - Function annotated with @this used as argument without bind(<non-null-receiver>) 237 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:227: ERROR - Function annotated with @this used as argument without a receiver. This check can be suppressed using @suppre ssReceiverCheck annotation on function declaration.
238 this.memberTwo(callbackWithThis); // ERROR - Used as argument with no bo und receiver. 238 this.memberTwo(callbackWithThis); // ERROR - Used as argument with no bo und receiver.
239 ^ 239 ^
240 240
241 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:228: ERROR - Receiver not specified for a function annotated with @this 241 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:228: ERROR - Receiver not specified for a function annotated with @this
242 this.memberTwo(callbackWithThis.bind(null, 2)); // ERROR - Used as argum ent with no bound receiver (null means "no receiver"). 242 this.memberTwo(callbackWithThis.bind(null, 2)); // ERROR - Used as argum ent with no bound receiver (null means "no receiver").
243 ^ 243 ^
244 244
245 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:229: ERROR - Receiver specified for a func tion not annotated with @this 245 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:229: ERROR - Receiver specified for a func tion not annotated with @this
246 this.memberTwo(callbackNoThis.bind(this)); // ERROR - Bound to a receive r but has no @this annotation. 246 this.memberTwo(callbackNoThis.bind(this)); // ERROR - Bound to a receive r but has no @this annotation.
247 ^ 247 ^
248 248
249 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:230: ERROR - Receiver specified for a func tion not annotated with @this 249 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:230: ERROR - Receiver specified for a func tion not annotated with @this
250 this.memberTwo(callbackNoThis.bind(foo)); // ERROR - Bound to a receiver but has no @this annotation. 250 this.memberTwo(callbackNoThis.bind(foo)); // ERROR - Bound to a receiver but has no @this annotation.
251 ^ 251 ^
252 252
253 Total errors: 63 253 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:237: ERROR - Function annotated with @this used as argument without a receiver. This check can be suppressed using @suppre ssReceiverCheck annotation on function declaration.
254 array.forEach(callbackWithThis); // ERROR - No receiver.
255 ^
256
257 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:238: ERROR - Function not annotated with @ this used as argument with a receiver. This check can be suppressed using @suppr essReceiverCheck annotation on function declaration.
258 array.forEach(callbackNoThis, this); // ERROR - Receiver for callback wi th no @this annotation.
259 ^
260
261 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:247: ERROR - Function not annotated with @ this used as argument with a receiver. This check can be suppressed using @suppr essReceiverCheck annotation on function declaration.
262 element.addEventListener("click", callbackNoThis, this); // ERROR.
263 ^
264
265 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:253: ERROR - Function annotated with @this used as argument without a receiver. This check can be suppressed using @suppre ssReceiverCheck annotation on function declaration.
266 element.addEventListener("click", callbackWithThis, true); // ERROR.
267 ^
268
269 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:254: ERROR - Function annotated with @this used as argument without a receiver. This check can be suppressed using @suppre ssReceiverCheck annotation on function declaration.
270 element.addEventListener("click", callbackWithThis, false); // ERROR.
271 ^
272
273 Total errors: 68
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698