Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java

Issue 203443010: DevTools: [JsDocValidator] Fix checking of receivers specified as arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a suppression hint message Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java
diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java
index c4e9165923d808b47181c067f07b93e78f26f9b1..d955ec984a11d2bb9e42566a55d76f1d4e82ec1e 100644
--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java
+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java
@@ -1,9 +1,13 @@
package org.chromium.devtools.jsdoc.checks;
import com.google.javascript.rhino.head.ast.AstNode;
+import com.google.javascript.rhino.head.ast.Comment;
+import com.google.javascript.rhino.head.ast.FunctionNode;
import org.chromium.devtools.jsdoc.ValidatorContext;
+import java.util.regex.Pattern;
+
abstract class ContextTrackingChecker {
private ContextTrackingState state;
@@ -23,7 +27,13 @@ abstract class ContextTrackingChecker {
return state.getContext();
}
- void reportErrorAtNodeStart(AstNode node, String errorText) {
+ protected boolean hasAnnotationTag(FunctionNode node, String tagName) {
+ Comment comment = AstUtil.getJsDocNode(node);
+ return comment != null &&
+ Pattern.matches("(?s).*@" + tagName + "\\b.*", getContext().getNodeText(comment));
+ }
+
+ protected void reportErrorAtNodeStart(AstNode node, String errorText) {
getContext().reportErrorInNode(node, 0, errorText);
}
}

Powered by Google App Engine
This is Rietveld 408576698