Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java - Issue 203443010: DevTools: [JsDocValidator] Fix checking of receivers specified as arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java

Issue 203443010: DevTools: [JsDocValidator] Fix checking of receivers specified as arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a suppression hint message Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionReceiverChecker.java ('k') | Source/devtools/scripts/jsdoc-validator/tests/golden.dat » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java

index 490438c3a98d505449b1511d9ddd07788c1b3c2a..191ad535c06c80bf7dca667a503bdcdd11845100 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/RequiredThisAnnotationChecker.java

@@ -37,7 +37,7 @@ public final class RequiredThisAnnotationChecker extends ContextTrackingChecker

if (!functionsRequiringThisAnnotation.contains(function)) {

AstNode functionNameNode = AstUtil.getFunctionNameNode(functionNode);

if (functionNameNode != null && !function.isTopLevelFunction() &&

- AstUtil.hasThisAnnotation(functionNode, getContext())) {

+ hasAnnotationTag(functionNode, "this")) {

reportErrorAtNodeStart(

functionNameNode,

"@this annotation found for function not referencing 'this'");

@@ -45,7 +45,7 @@ public final class RequiredThisAnnotationChecker extends ContextTrackingChecker

return;

}

AstNode functionNameNode = AstUtil.getFunctionNameNode(functionNode);

- if (functionNameNode != null && !AstUtil.hasThisAnnotation(functionNode, getContext())) {

+ if (functionNameNode != null && !hasAnnotationTag(functionNode, "this")) {

reportErrorAtNodeStart(

functionNameNode,

"@this annotation is required for functions referencing 'this'");