Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2034273003: Change WebMediaPlayer::trackId to be the same as byteStreamTrackId (Closed)

Created:
4 years, 6 months ago by servolk
Modified:
4 years, 6 months ago
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, blink-reviews-api_chromium.org, haraken, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change WebMediaPlayer::trackId to be the same as byteStreamTrackId

Patch Set 1 #

Patch Set 2 : buildfix #

Patch Set 3 : Buildfixes #

Patch Set 4 : Buildfixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackBase.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
wolenetz
On 2016/06/04 00:08:13, servolk wrote: > mailto:servolk@chromium.org changed reviewers: > + mailto:chcunningham@chromium.org, mailto:wolenetz@chromium.org, mailto:xhwang@chromium.org Is ...
4 years, 6 months ago (2016-06-07 20:23:54 UTC) #2
servolk
4 years, 6 months ago (2016-06-09 23:41:16 UTC) #3 
On 2016/06/07 20:23:54, wolenetz_slow_reviews wrote:
> On 2016/06/04 00:08:13, servolk wrote:
> > mailto:servolk@chromium.org changed reviewers:
> > + mailto:chcunningham@chromium.org, mailto:wolenetz@chromium.org,
> mailto:xhwang@chromium.org
> 
> Is this change no longer the route forward, per
> https://codereview.chromium.org/1922333002/#msg22 ?

It's been merged into https://codereview.chromium.org/2050043002/, so I'll close
this CL.

Powered by Google App Engine
This is Rietveld 408576698