media/blink/webmediaplayer_impl_unittest.cc - Issue 2034273003: Change WebMediaPlayer::trackId to be the same as byteStreamTrackId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2034273003: Change WebMediaPlayer::trackId to be the same as byteStreamTrackId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Buildfixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webmediaplayer_ms_unittest.cc ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/blink/webmediaplayer_impl_unittest.cc

diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc

index bfa30eaea6ff27643720d61156e94004a46c8164..9d20e635108334acf678941da8c72f0b4cd8540b 100644

--- a/media/blink/webmediaplayer_impl_unittest.cc

+++ b/media/blink/webmediaplayer_impl_unittest.cc

@@ -56,7 +56,7 @@ class DummyWebMediaPlayerClient : public blink::WebMediaPlayerClient {

const blink::WebString& label,

const blink::WebString& language,

bool enabled) override {

- return 0;

+ return blink::WebString();

}

void removeAudioTrack(blink::WebMediaPlayer::TrackId) override {}

blink::WebMediaPlayer::TrackId addVideoTrack(

@@ -65,7 +65,7 @@ class DummyWebMediaPlayerClient : public blink::WebMediaPlayerClient {

const blink::WebString& label,

const blink::WebString& language,

bool selected) override {

- return 0;

+ return blink::WebString();

}

void removeVideoTrack(blink::WebMediaPlayer::TrackId) override {}

void addTextTrack(blink::WebInbandTextTrack*) override {}

« no previous file with comments | « content/renderer/media/webmediaplayer_ms_unittest.cc ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »