Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Issue 2034273003: Change WebMediaPlayer::trackId to be the same as byteStreamTrackId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Buildfixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
index 4dbe8dffb32779fd9cf0a325362128c16812c253..5d9a5997d7c5e42189de88bfea6efda4c98df8b7 100644
--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
@@ -588,8 +588,7 @@ WebVector<WebMediaPlayer::TrackId> SourceBuffer::initializationSegmentReceived(c
unsigned resultIdx = 0;
for (const auto& trackInfo : newTracks) {
if (!RuntimeEnabledFeatures::audioVideoTracksEnabled()) {
- static WebMediaPlayer::TrackId nextTrackId = 0;
- result[resultIdx++] = ++nextTrackId;
+ result[resultIdx++] = "";
continue;
}
@@ -625,9 +624,10 @@ WebVector<WebMediaPlayer::TrackId> SourceBuffer::initializationSegmentReceived(c
}
(void)trackBase;
#if !LOG_DISABLED
- const char* logActionStr = m_firstInitializationSegmentReceived ? "using existing" : "added";
- const char* logTrackTypeStr = (trackInfo.trackType == WebMediaPlayer::AudioTrack) ? "audio" : "video";
- WTF_LOG(Media, "Tracks (sb=%p): %s %sTrack %p trackId=%d id=%s label=%s lang=%s", this, logActionStr, logTrackTypeStr, trackBase, trackBase->trackId(), trackBase->id().utf8().data(), trackBase->label().utf8().data(), trackBase->language().utf8().data());
+ // TODO(servolk): WTF_LOG is deprecated, replace with DVLOG.
+ // const char* logActionStr = m_firstInitializationSegmentReceived ? "using existing" : "added";
+ // const char* logTrackTypeStr = (trackInfo.trackType == WebMediaPlayer::AudioTrack) ? "audio" : "video";
+ // WTF_LOG(Media, "Tracks (sb=%p): %s %sTrack %p id=%s label=%s lang=%s", this, logActionStr, logTrackTypeStr, trackBase, trackBase->id().utf8().data(), trackBase->label().utf8().data(), trackBase->language().utf8().data());
#endif
}
« no previous file with comments | « third_party/WebKit/Source/core/html/track/TrackBase.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698