recipes: Switch from 3 ways for requesting clobber builds to 1

recipes: Switch from 3 ways for requesting clobber builds to 1

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter and make it
look only at the first signal.

The motivation is that once this is done in a unified way, clobber can
be moved to a separate step that runs before runhooks and
generate_buidl_files instead of during compile – then clobbering doesn't
have to be careful to not delete ninja files, isolate files, and other things
that are generated by runhooks and generate_build_files.

No intended behavior change.

BUG=574557
Committed: https://chromium.googlesource.com/chromium/tools/build/+/b55273d810342bb785b961f614247ae9d4c4e631

[Nico, 2016-06-01 23:32:20]

Description was changed from

==========
recipes: Switch from 4 ways for requesting clobber builds to 2

wip doesn't work yet

BUG=574557
==========

to

==========
recipes: Switch from 3 ways for requesting clobber builds to 2

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter.

No intended behavior change.

BUG=574557
==========

[Nico, 2016-06-01 23:36:38]

Description was changed from

==========
recipes: Switch from 3 ways for requesting clobber builds to 2

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter.

No intended behavior change.

BUG=574557
==========

to

==========
recipes: Switch from 3 ways for requesting clobber builds to 2

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter.

The motivation is that once this is done in a unified way, clobber can
be moved to a separate step that runs before runhooks and
generate_buidl_files instead of during compile – then clobbering doesn't
have to be careful to not delete ninja files, isolate files, and other things
that are generated by runhooks and generate_build_files.

No intended behavior change.

BUG=574557
==========

[Nico, 2016-06-01 23:36:54]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org, sebmarchand@chromium.org

[Nico, 2016-06-01 23:36:55]

sebmarchand: pgo stuff
dpranke: rest

https://codereview.chromium.org/2033513002/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/pgo/example.py (right):

https://codereview.chromium.org/2033513002/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/pgo/example.py:46: buildername, bot_config =
api.chromium.configure_bot(TEST_BUILDERS, [])
This makes the file more similar to most other files. I had a
chromium_apply_config in this file for a while (now removed again), and it took
me a while to figure out why that didn't work. Seems like a good idea to make
this more similar to the other files, so I kept this change.

https://codereview.chromium.org/2033513002/diff/80001/scripts/slave/recipes/c...
File
scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json
(right):

https://codereview.chromium.org/2033513002/diff/80001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json:177:
"--clobber",
This is new, but it seems correct that the instrumentation phase either needs a
clobber or doesn't, consistently.

[Nico, 2016-06-01 23:42:52]

Description was changed from

==========
recipes: Switch from 3 ways for requesting clobber builds to 2

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter.

The motivation is that once this is done in a unified way, clobber can
be moved to a separate step that runs before runhooks and
generate_buidl_files instead of during compile – then clobbering doesn't
have to be careful to not delete ninja files, isolate files, and other things
that are generated by runhooks and generate_build_files.

No intended behavior change.

BUG=574557
==========

to

==========
recipes: Switch from 3 ways for requesting clobber builds to 1

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter and make it
look only at the first signal.

The motivation is that once this is done in a unified way, clobber can
be moved to a separate step that runs before runhooks and
generate_buidl_files instead of during compile – then clobbering doesn't
have to be careful to not delete ninja files, isolate files, and other things
that are generated by runhooks and generate_build_files.

No intended behavior change.

BUG=574557
==========

[Nico, 2016-06-01 23:43:34]

actually, I removed self.m.properties.get('clobber') from compile() as well. It
didn't change any recipe expectations. (Do I need to check any internal
expectations? How do I do that?)

[Sébastien Marchand, 2016-06-02 01:44:30]

lgtm, I think that recipe_roller will automatically update the internal test
expectations if needed (the internal PGO recipe doesn't use "'clobber': True" in
its config).

[Dirk Pranke, 2016-06-02 01:49:13]

lgtm.

cc'ing phajdan in case he's curious.

https://codereview.chromium.org/2033513002/diff/160001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/pgo/example.py (right):

https://codereview.chromium.org/2033513002/diff/160001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/pgo/example.py:51: for buildername in
TEST_BUILDERS[mastername]['builders']:
given that there's only one builder here, these nested loops are overkill either
way ...

[Nico, 2016-06-02 02:40:41]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:40:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033513002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033513002/160001

[commit-bot: I haz the power, 2016-06-02 02:46:21]

Description was changed from

==========
recipes: Switch from 3 ways for requesting clobber builds to 1

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter and make it
look only at the first signal.

The motivation is that once this is done in a unified way, clobber can
be moved to a separate step that runs before runhooks and
generate_buidl_files instead of during compile – then clobbering doesn't
have to be careful to not delete ninja files, isolate files, and other things
that are generated by runhooks and generate_build_files.

No intended behavior change.

BUG=574557
==========

to

==========
recipes: Switch from 3 ways for requesting clobber builds to 1

Some bots applied the clobber config, some set force_clobber when
calling compile(), and some set clobber: true on the bot. Move to the
first, and remove compile()'s force_clobber parameter and make it
look only at the first signal.

The motivation is that once this is done in a unified way, clobber can
be moved to a separate step that runs before runhooks and
generate_buidl_files instead of during compile – then clobbering doesn't
have to be careful to not delete ninja files, isolate files, and other things
that are generated by runhooks and generate_build_files.

No intended behavior change.

BUG=574557

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b55273d810342bb785b9...
==========

[commit-bot: I haz the power, 2016-06-02 02:46:23]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/tools/build/+/b55273d810342bb785b9...