Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: scripts/slave/recipes/chromium_gn_upload.py

Issue 2033513002: recipes: Switch from 3 ways for requesting clobber builds to 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: presubmit2 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_gn_upload.py
diff --git a/scripts/slave/recipes/chromium_gn_upload.py b/scripts/slave/recipes/chromium_gn_upload.py
index c924d87c57d12bcfbb11c910652c8a0f57c278f2..1f3c4b592ac2c9054800c6d6e164efafb0aab25d 100644
--- a/scripts/slave/recipes/chromium_gn_upload.py
+++ b/scripts/slave/recipes/chromium_gn_upload.py
@@ -26,6 +26,7 @@ BUILDERS = freeze({
'TARGET_PLATFORM': 'linux',
'TARGET_BITS': 64,
},
+ 'chromium_apply_config': ['clobber'],
# We need this to pull the Linux sysroots.
'gclient_apply_config': ['chrome_internal'],
@@ -40,6 +41,7 @@ BUILDERS = freeze({
'TARGET_PLATFORM': 'mac',
'TARGET_BITS': 64,
},
+ 'chromium_apply_config': ['clobber'],
},
},
},
@@ -51,6 +53,7 @@ BUILDERS = freeze({
'TARGET_PLATFORM': 'win',
'TARGET_BITS': 32,
},
+ 'chromium_apply_config': ['clobber'],
},
},
},
@@ -69,7 +72,7 @@ def RunSteps(api):
api.chromium.run_mb(mastername, buildername)
- api.chromium.compile(targets=['gn', 'gn_unittests'], force_clobber=True)
+ api.chromium.compile(targets=['gn', 'gn_unittests'])
path_to_binary = str(api.path['checkout'].join('out', 'Release', 'gn'))
if api.platform.is_win:

Powered by Google App Engine
This is Rietveld 408576698