recipes: Switch from 3 ways for requesting clobber builds to 1

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
@@ skipping 137 matching lines @@
     # Note that we have to call gclient.set_config() and apply_config() *after*
     # calling chromium.set_config(), above, because otherwise the chromium
     # call would reset the gclient config to its defaults.
     self.m.gclient.set_config(
         'chromium', PATCH_PROJECT=self.m.properties.get('patch_project'))
     for c in bot_config.get('gclient_apply_config', []):
       self.m.gclient.apply_config(c)
 
     return (buildername, bot_config)
 
-  def compile(self, targets=None, name=None, force_clobber=False, out_dir=None,
+  def compile(self, targets=None, name=None, out_dir=None,
               target=None, **kwargs):
     """Return a compile.py invocation."""
     targets = targets or self.c.compile_py.default_targets.as_jsonish()
     assert isinstance(targets, (list, tuple))
 
     if self.c.gyp_env.GYP_DEFINES.get('clang', 0) == 1:
       # Get the Clang revision before compiling.
       self._clang_version = self.get_clang_version()
 
     args = [
@@ skipping 43 matching lines @@
     if self.c.compile_py.goma_store_local_run_output:
       args += ['--goma-store-local-run-output']
     if self.c.compile_py.goma_enable_compiler_info_cache:
       args += ['--goma-enable-compiler-info-cache']
     if self.m.tryserver.is_tryserver:
       # We rely on goma to meet cycle time goals on the tryserver. It's better
       # to fail early.
       args += ['--goma-fail-fast', '--goma-disable-local-fallback']
     if self.c.compile_py.ninja_confirm_noop:
       args.append('--ninja-ensure-up-to-date')
-    if (self.m.properties.get('clobber') is not None or
-        self.c.compile_py.clobber or
-        force_clobber):
+    if self.c.compile_py.clobber:
       args.append('--clobber')
     if self.c.compile_py.pass_arch_flag:
       args += ['--arch', self.c.gyp_env.GYP_DEFINES['target_arch']]
     if self.c.TARGET_CROS_BOARD:
       args += ['--cros-board', self.c.TARGET_CROS_BOARD]
 
     assert not self.c.compile_py.solution
     args.append('--')
     if self.c.compile_py.build_tool == 'xcode':
       if self.c.compile_py.xcode_project:  # pragma: no cover
@@ skipping 524 matching lines @@
       }))
 
   def get_annotate_by_test_name(self, test_name):
     return 'graphing'
 
   def download_lto_plugin(self):
     return self.m.python(
         name='download LTO plugin',
         script=self.m.path['checkout'].join(
             'build', 'download_gold_plugin.py'))