Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2033513002: recipes: Switch from 3 ways for requesting clobber builds to 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: presubmit2 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 3f30a642c558ac1dc1189d510fca686d42e9504d..4efaa631ee8939f14141f52dc7cc4b2d06a11898 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -155,7 +155,7 @@ class ChromiumApi(recipe_api.RecipeApi):
return (buildername, bot_config)
- def compile(self, targets=None, name=None, force_clobber=False, out_dir=None,
+ def compile(self, targets=None, name=None, out_dir=None,
target=None, **kwargs):
"""Return a compile.py invocation."""
targets = targets or self.c.compile_py.default_targets.as_jsonish()
@@ -219,9 +219,7 @@ class ChromiumApi(recipe_api.RecipeApi):
args += ['--goma-fail-fast', '--goma-disable-local-fallback']
if self.c.compile_py.ninja_confirm_noop:
args.append('--ninja-ensure-up-to-date')
- if (self.m.properties.get('clobber') is not None or
- self.c.compile_py.clobber or
- force_clobber):
+ if self.c.compile_py.clobber:
args.append('--clobber')
if self.c.compile_py.pass_arch_flag:
args += ['--arch', self.c.gyp_env.GYP_DEFINES['target_arch']]
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | scripts/slave/recipe_modules/pgo/example.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698