Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2033503002: Add StringView::toAtomicString(). (Closed)

Created:
4 years, 6 months ago by esprehn
Modified:
4 years, 6 months ago
Reviewers:
haraken, Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-wtf_chromium.org, chromium-reviews, dglazkov+blink, Mikhail, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add StringView::toAtomicString(). We should go directly from the LChar*/UChar* to an AtomicString which saves doing the malloc and copy of a temporary StringImpl to pass into the AtomicString constructor. Instead if we pass the bytes and length the HashSet translator can directly hash the bytes and lookup the existing atomic StringImpl. BUG=615174 Committed: https://crrev.com/07dd6f5d6b4603cde39464177d6fac57b7835317 Cr-Commit-Position: refs/heads/master@{#397306}

Patch Set 1 #

Patch Set 2 : Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringView.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringView.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringViewTest.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
esprehn
4 years, 6 months ago (2016-06-01 22:43:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033503002/20001
4 years, 6 months ago (2016-06-01 22:43:28 UTC) #4
haraken
LGTM
4 years, 6 months ago (2016-06-01 23:41:24 UTC) #5
Timothy Loh
lgtm
4 years, 6 months ago (2016-06-02 02:03:04 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/223144)
4 years, 6 months ago (2016-06-02 02:04:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033503002/20001
4 years, 6 months ago (2016-06-02 02:07:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239448)
4 years, 6 months ago (2016-06-02 02:33:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033503002/20001
4 years, 6 months ago (2016-06-02 03:25:17 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239541)
4 years, 6 months ago (2016-06-02 04:13:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033503002/20001
4 years, 6 months ago (2016-06-02 05:06:12 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 06:03:33 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:04:49 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07dd6f5d6b4603cde39464177d6fac57b7835317
Cr-Commit-Position: refs/heads/master@{#397306}

Powered by Google App Engine
This is Rietveld 408576698