third_party/WebKit/Source/wtf/text/StringView.cpp - Issue 2033503002: Add StringView::toAtomicString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringView.cpp

Issue 2033503002: Add StringView::toAtomicString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringView.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringView.cpp b/third_party/WebKit/Source/wtf/text/StringView.cpp

index 6135d8d258118808288766b95b247f8f5c0df942..8fc2238358b8962926da02415899ce2e60080681 100644

--- a/third_party/WebKit/Source/wtf/text/StringView.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringView.cpp

@@ -35,6 +35,17 @@ String StringView::toString() const

return StringImpl::create8BitIfPossible(m_data.characters16, m_length);

}

+AtomicString StringView::toAtomicString() const

+ if (isNull())

+ return nullAtom;

+ if (isEmpty())

+ return emptyAtom;

+ if (is8Bit())

+ return AtomicString(m_data.characters8, m_length);

+ return AtomicString(m_data.characters16, m_length);

bool equalStringView(const StringView& a, const StringView& b)

{

if (a.isNull() || b.isNull())