Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Issue 2033503002: Add StringView::toAtomicString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
index c753715ee440784f1a36650b705b886a228cb299..cb13be552c9afe727725a340aa1cebce30d74334 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
@@ -190,14 +190,14 @@ CSSSelectorList CSSParserImpl::parsePageSelector(CSSParserTokenRange range, Styl
range.consumeWhitespace();
AtomicString typeSelector;
if (range.peek().type() == IdentToken)
- typeSelector = AtomicString(range.consume().value().toString());
+ typeSelector = range.consume().value().toAtomicString();
AtomicString pseudo;
if (range.peek().type() == ColonToken) {
range.consume();
if (range.peek().type() != IdentToken)
return CSSSelectorList();
- pseudo = AtomicString(range.consume().value().toString());
+ pseudo = range.consume().value().toAtomicString();
}
range.consumeWhitespace();
@@ -436,7 +436,7 @@ static AtomicString consumeStringOrURI(CSSParserTokenRange& range)
const CSSParserToken& token = range.peek();
if (token.type() == StringToken || token.type() == UrlToken)
- return AtomicString(range.consumeIncludingWhitespace().value().toString());
+ return range.consumeIncludingWhitespace().value().toAtomicString();
if (token.type() != FunctionToken || !token.valueEqualsIgnoringASCIICase("url"))
return AtomicString();
@@ -446,7 +446,7 @@ static AtomicString consumeStringOrURI(CSSParserTokenRange& range)
ASSERT(uri.type() == StringToken);
if (!contents.atEnd())
return AtomicString();
- return AtomicString(uri.value().toString());
+ return uri.value().toAtomicString();
}
StyleRuleCharset* CSSParserImpl::consumeCharsetRule(CSSParserTokenRange prelude)
@@ -481,7 +481,7 @@ StyleRuleNamespace* CSSParserImpl::consumeNamespaceRule(CSSParserTokenRange prel
prelude.consumeWhitespace();
AtomicString namespacePrefix;
if (prelude.peek().type() == IdentToken)
- namespacePrefix = AtomicString(prelude.consumeIncludingWhitespace().value().toString());
+ namespacePrefix = prelude.consumeIncludingWhitespace().value().toAtomicString();
AtomicString uri(consumeStringOrURI(prelude));
prelude.consumeWhitespace();
@@ -772,7 +772,7 @@ void CSSParserImpl::consumeDeclaration(CSSParserTokenRange range, StyleRule::Rul
size_t propertiesCount = m_parsedProperties.size();
if (RuntimeEnabledFeatures::cssVariablesEnabled() && unresolvedProperty == CSSPropertyInvalid && CSSVariableParser::isValidVariableName(token)) {
- AtomicString variableName = AtomicString(token.value().toString());
+ AtomicString variableName = token.value().toAtomicString();
consumeVariableValue(range.makeSubRange(&range.peek(), declarationValueEnd), variableName, important);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698