third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2033503002: Add StringView::toAtomicString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2033503002: Add StringView::toAtomicString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index f39c0326705308172e086d475e02edbbe811b426..db7028ed731658d6efcc6c3c8a636b2633f2306c 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -393,7 +393,7 @@ static CSSFontFeatureValue* consumeFontFeatureTag(CSSParserTokenRange& range)

return nullptr;

if (token.value().length() != tagNameLength)

return nullptr;

- AtomicString tag = AtomicString(token.value().toString());

+ AtomicString tag = token.value().toAtomicString();

for (unsigned i = 0; i < tagNameLength; ++i) {

// Limits the range of characters to 0x20-0x7E, following the tag name rules defiend in the OpenType specification.

UChar character = tag[i];