core/fxcodec/codec/fx_codec_jpeg.cpp - Issue 2032613003: Get rid of NULLs in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/fx_codec_jpeg.cpp

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Git rid of comparisons against NULL Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/codec/fx_codec_jpeg.cpp

diff --git a/core/fxcodec/codec/fx_codec_jpeg.cpp b/core/fxcodec/codec/fx_codec_jpeg.cpp

index c41dde943f040e9ad866dfa4950e70b9845c00f3..4646dd609e8dbd38d7e38b680ee97def0b1ff0f2 100644

--- a/core/fxcodec/codec/fx_codec_jpeg.cpp

+++ b/core/fxcodec/codec/fx_codec_jpeg.cpp

@@ -234,9 +234,6 @@ static void _JpegEncode(const CFX_DIBSource* pSource,

#ifdef PDF_ENABLE_XFA

static void _JpegLoadAttribute(struct jpeg_decompress_struct* pInfo,

CFX_DIBAttribute* pAttribute) {

- if (pInfo == NULL || pAttribute == NULL) {

- return;

- }

if (pAttribute) {

Tom Sepez 2016/06/02 20:09:48 Agree that pInfo is nonzero in its one caller.

Lei Zhang 2016/06/07 07:33:23 Acknowledged.

pAttribute->m_nXDPI = pInfo->X_density;

pAttribute->m_nYDPI = pInfo->Y_density;