Get rid of NULLs in core/

core/fxcodec/codec/fx_codec_jpeg.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <setjmp.h>
 
 #include "core/fxcodec/codec/codec_int.h"
 #include "core/fxcodec/include/fx_codec.h"
@@ skipping 216 matching lines @@
   }
   jpeg_finish_compress(&cinfo);
   jpeg_destroy_compress(&cinfo);
   FX_Free(line_buf);
   dest_size = dest_buf_length - (FX_STRSIZE)dest.free_in_buffer;
 }
 
 #ifdef PDF_ENABLE_XFA
 static void _JpegLoadAttribute(struct jpeg_decompress_struct* pInfo,
                                CFX_DIBAttribute* pAttribute) {
-  if (pInfo == NULL || pAttribute == NULL) {
-    return;
-  }
   if (pAttribute) {

[Tom Sepez, 2016/06/02 20:09:48]

Agree that pInfo is nonzero in its one caller.

[Lei Zhang, 2016/06/07 07:33:23]

Acknowledged.

     pAttribute->m_nXDPI = pInfo->X_density;
     pAttribute->m_nYDPI = pInfo->Y_density;
     pAttribute->m_wDPIUnit = pInfo->density_unit;
   }
 }
 #endif  // PDF_ENABLE_XFA
 
 static FX_BOOL _JpegLoadInfo(const uint8_t* src_buf,
                              uint32_t src_size,
                              int& width,
@@ skipping 396 matching lines @@
 uint32_t CCodec_JpegModule::GetAvailInput(FXJPEG_Context* ctx,
                                           uint8_t** avail_buf_ptr) {
   if (avail_buf_ptr) {
     *avail_buf_ptr = NULL;
     if (ctx->m_SrcMgr.bytes_in_buffer > 0) {
       *avail_buf_ptr = (uint8_t*)ctx->m_SrcMgr.next_input_byte;
     }
   }
   return (uint32_t)ctx->m_SrcMgr.bytes_in_buffer;
 }