core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp - Issue 2032613003: Get rid of NULLs in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Git rid of comparisons against NULL Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

index 994c1c8a5a38fde1e4c95f3c9ac40b40576d3085..bf98fdf0d1fd07ce9974b1f6d5d8bd496caf433f 100644

--- a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

@@ -1556,7 +1556,7 @@ int32_t CPDF_Creator::WriteDoc_Stage2(IFX_Pause* pPause) {

m_iStage = 27;

}

if (m_iStage == 27) {

- if (NULL != m_pEncryptDict && 0 == m_pEncryptDict->GetObjNum()) {

+ if (m_pEncryptDict && 0 == m_pEncryptDict->GetObjNum()) {

Tom Sepez 2016/06/02 20:09:48 nit: mumble == 0 rather than 0 == mumble.

Lei Zhang 2016/06/07 07:33:23 Someone else took care of it.

m_dwLastObjNum += 1;

FX_FILESIZE saveOffset = m_Offset;

if (WriteIndirectObj(m_dwLastObjNum, m_pEncryptDict) < 0) {