core/fxcodec/codec/fx_codec_icc.cpp - Issue 2032613003: Get rid of NULLs in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/fx_codec_icc.cpp

Issue 2032613003: Get rid of NULLs in core/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Git rid of comparisons against NULL Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/codec/fx_codec_icc.cpp

diff --git a/core/fxcodec/codec/fx_codec_icc.cpp b/core/fxcodec/codec/fx_codec_icc.cpp

index 876297fd40faf210504a27dda10b6123451fa0e8..9149d144bd53c9484ca05db52be198363f796acd 100644

--- a/core/fxcodec/codec/fx_codec_icc.cpp

+++ b/core/fxcodec/codec/fx_codec_icc.cpp

@@ -499,7 +499,7 @@ void* CCodec_IccModule::CreateTransform(

pProofProfile = CreateProfile(pProofParam, Icc_CLASS_PROOF, &key);

}

key << dwInputProfileType << dwOutputProfileType << dwIntent << dwFlag

- << (pProofProfile != NULL) << dwPrfIntent << dwPrfFlag;

+ << !!pProofProfile << dwPrfIntent << dwPrfFlag;

CFX_ByteString TransformKey(key.GetBuffer(), key.GetSize());

CFX_IccTransformCache* pTransformCache;

auto it = m_MapTranform.find(TransformKey);