Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2030473002: ABANDONED CL: Using ResourceRequestBody as the type of browser_initiated_post_data. (Closed)

Created:
4 years, 6 months ago by Łukasz Anforowicz
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, ajwong+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, loading-reviews_chromium.org, mlamouri+watch-content_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, Peter Beverloo, gavinp+prer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, davidben+watch_chromium.org, Aaron Boodman, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@make-resource-request-body-public
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED - replaced with a fresh CL at https://codereview.chromium.org/2038233002/ ------------------------------------------- Using ResourceRequestBody as the type of browser_initiated_post_data. TODO / DO NOT SUBMIT: Real CL description. BUG=344348 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -149 lines) Patch
M chrome/browser/android/tab_android.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 2 chunks +9 lines, -12 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 5 chunks +11 lines, -19 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 5 chunks +9 lines, -22 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl_unittest.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M content/browser/net/network_errors_listing_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/resource_request_body_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/resource_request_body_impl.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 3 chunks +7 lines, -8 lines 0 comments Download
M content/public/browser/navigation_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/navigation_entry.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/page_navigator.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/public/common/resource_request_body.h View 1 chunk +21 lines, -0 lines 0 comments Download
M content/public/common/resource_request_body.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/shell/browser/shell.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 2008613002 Patch 80001

Messages

Total messages: 1 (1 generated)
Łukasz Anforowicz
4 years, 6 months ago (2016-06-04 00:04:37 UTC) #1 
Description was changed from

==========
Using ResourceRequestBody as the type of browser_initiated_post_data.

TODO / DO NOT SUBMIT: Real CL description.

BUG=344348
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
ABANDONED - replaced with a fresh CL at
https://codereview.chromium.org/2038233002/

-------------------------------------------

Using ResourceRequestBody as the type of browser_initiated_post_data.

TODO / DO NOT SUBMIT: Real CL description.

BUG=344348
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698