content/browser/frame_host/navigation_controller_impl.cc - Issue 2030473002: ABANDONED CL: Using ResourceRequestBody as the type of browser_initiated_post_data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2030473002: ABANDONED CL: Using ResourceRequestBody as the type of browser_initiated_post_data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-resource-request-body-public

Patch Set: Rebasing... Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_android.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index fe5cdcd0f764db3adaa7b8a7932f6907fb31d66d..6149183878daced05d829ca31c821d11e31cc33c 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -669,7 +669,7 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {

switch (params.load_type) {

case LOAD_TYPE_DEFAULT:

break;

- case LOAD_TYPE_BROWSER_INITIATED_HTTP_POST:

+ case LOAD_TYPE_HTTP_POST:

if (!params.url.SchemeIs(url::kHttpScheme) &&

!params.url.SchemeIs(url::kHttpsScheme)) {

NOTREACHED() << "Http post load must use http(s) scheme.";

@@ -768,10 +768,9 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {

switch (params.load_type) {

case LOAD_TYPE_DEFAULT:

break;

- case LOAD_TYPE_BROWSER_INITIATED_HTTP_POST:

+ case LOAD_TYPE_HTTP_POST:

entry->SetHasPostData(true);

- entry->SetBrowserInitiatedPostData(

- params.browser_initiated_post_data.get());

+ entry->SetPostData(params.post_data.get());

break;

case LOAD_TYPE_DATA:

entry->SetBaseURLForDataURL(params.base_url_for_data_url);