Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2008613002: ABANDONED CL: Making ResourceRequestBody part of //content's public API. (Closed)

Created:
4 years, 7 months ago by Łukasz Anforowicz
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, tzik, nasko+codewatch_chromium.org, jam, nhiroki, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, loading-reviews_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@post-data-my-stuff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED - restarted the CL with a clean slate in https://codereview.chromium.org/2038813003/ --------------------- Making ResourceRequestBody part of //content's public API. This CL adds support for passing ResourceRequestBody instances outside of //content layer. This will be utilized by a later CL that needs to add ResourceRequestBody to OpenURLParams (already part of //content's public API) in order to support passing POST body from a form that targets a remote frame (aka an OOPIF). Outside of //content layer, ResourceRequestBody exposes only minimal functionality: 1. Ability to create it from a vector of bytes (to support passing post body in case of a browser initiated post navigation). 2. Ability to ref-count. There are no scenarios today where content of ResourceRequestBody would need to be inspected outside of //content's internal implementation details. BUG=585284 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Rebasing... #

Patch Set 3 : Rebasing... #

Patch Set 4 : Fixing merge conflict resolutions that broken compile... #

Patch Set 5 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -363 lines) Patch
M content/browser/frame_host/frame_navigation_entry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_navigation_entry.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 4 chunks +11 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/DEPS View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/navigation_resource_throttle.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/upload_data_stream_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder.cc View 5 chunks +21 lines, -19 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/resource_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_request_util.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M content/child/web_url_request_util.cc View 1 2 3 5 chunks +12 lines, -11 lines 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/navigation_params.h View 1 3 chunks +17 lines, -16 lines 0 comments Download
M content/common/navigation_params.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/page_state_serialization.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/page_state_serialization.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M content/common/resource_messages.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/resource_messages.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M content/common/resource_request.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/resource_request_body.h View 1 1 chunk +0 lines, -70 lines 0 comments Download
D content/common/resource_request_body.cc View 1 1 chunk +0 lines, -54 lines 0 comments Download
A + content/common/resource_request_body_impl.h View 1 4 chunks +9 lines, -10 lines 0 comments Download
A + content/common/resource_request_body_impl.cc View 1 4 chunks +7 lines, -10 lines 0 comments Download
M content/content_common.gypi View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M content/public/common/page_state.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A content/public/common/resource_request_body.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A + content/public/common/resource_request_body.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (2 generated)
Łukasz Anforowicz
Description was changed from ========== Making ResourceRequestBody part of //content's public API. This CL adds ...
4 years, 7 months ago (2016-05-23 18:51:52 UTC) #1
Łukasz Anforowicz
4 years, 6 months ago (2016-06-03 23:39:16 UTC) #2
Description was changed from

==========
Making ResourceRequestBody part of //content's public API.

This CL adds support for passing ResourceRequestBody instances outside
of //content layer.  This will be utilized by a later CL that needs to
add ResourceRequestBody to OpenURLParams (already part of //content's
public API) in order to support passing POST body from a form that
targets a remote frame (aka an OOPIF).

Outside of //content layer, ResourceRequestBody exposes only minimal
functionality:
1. Ability to create it from a vector of bytes (to support passing
   post body in case of a browser initiated post navigation).
2. Ability to ref-count.
There are no scenarios today where content of ResourceRequestBody would
need to be inspected outside of //content's internal implementation
details.

BUG=585284
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
ABANDONED - restarted the CL with a clean slate in
https://codereview.chromium.org/2038813003/

---------------------

Making ResourceRequestBody part of //content's public API.

This CL adds support for passing ResourceRequestBody instances outside
of //content layer.  This will be utilized by a later CL that needs to
add ResourceRequestBody to OpenURLParams (already part of //content's
public API) in order to support passing POST body from a form that
targets a remote frame (aka an OOPIF).

Outside of //content layer, ResourceRequestBody exposes only minimal
functionality:
1. Ability to create it from a vector of bytes (to support passing
   post body in case of a browser initiated post navigation).
2. Ability to ref-count.
There are no scenarios today where content of ResourceRequestBody would
need to be inspected outside of //content's internal implementation
details.

BUG=585284
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698