ABANDONED CL: Using ResourceRequestBody as the type of browser_initiated_post_data.

chrome/browser/ui/browser_navigator_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_navigator_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
@@ skipping 15 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/omnibox/browser/omnibox_view.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/resource_request_body.h"
 #include "content/public/test/browser_test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 using content::WebContents;
 
 namespace {
 
 const char kExpectedTitle[] = "PASSED!";
 const char kEchoTitleCommand[] = "/echotitle";
 
@@ skipping 42 matching lines @@
 }
 
 bool BrowserNavigatorTest::OpenPOSTURLInNewForegroundTabAndGetTitle(
     const GURL& url, const std::string& post_data, bool is_browser_initiated,
     base::string16* title) {
   chrome::NavigateParams param(MakeNavigateParams());
   param.disposition = NEW_FOREGROUND_TAB;
   param.url = url;
   param.is_renderer_initiated = !is_browser_initiated;
   param.uses_post = true;
-  param.browser_initiated_post_data = new base::RefCountedStaticMemory(
-      post_data.data(), post_data.size());
+  param.post_data = content::ResourceRequestBody::CreateFromBytes(post_data);
 
   ui_test_utils::NavigateToURL(&param);
   if (!param.target_contents)
     return false;
 
   // Navigate() should have opened the contents in new foreground tab in the
   // current Browser.
   EXPECT_EQ(browser(), param.browser);
   EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents(),
             param.target_contents);
@@ skipping 1291 matching lines @@
   // Open a browser initiated POST request in new foreground tab.
   base::string16 expected_title(base::ASCIIToUTF16(kExpectedTitle));
   std::string post_data = kExpectedTitle;
   base::string16 title;
   ASSERT_TRUE(OpenPOSTURLInNewForegroundTabAndGetTitle(
       embedded_test_server()->GetURL(kEchoTitleCommand), post_data, true,
       &title));
   EXPECT_EQ(expected_title, title);
 }
 
-// This test verifies that renderer initiated navigations can NOT send requests
+// This test verifies that renderer initiated navigations can also send requests
 // using POST.
 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,
                        SendRendererInitiatedRequestUsingPOST) {
   // Uses a test sever to verify POST request.
   ASSERT_TRUE(embedded_test_server()->Start());
 
   // Open a renderer initiated POST request in new foreground tab.
   base::string16 expected_title(base::ASCIIToUTF16(kExpectedTitle));
   std::string post_data = kExpectedTitle;
   base::string16 title;
   ASSERT_TRUE(OpenPOSTURLInNewForegroundTabAndGetTitle(
       embedded_test_server()->GetURL(kEchoTitleCommand), post_data, false,
       &title));
-  EXPECT_NE(expected_title, title);
+  EXPECT_EQ(expected_title, title);
 }
 
 // This test navigates to a data URL that contains BiDi control
 // characters. For security reasons, BiDi control chars should always be
 // escaped in the URL but they should be unescaped in the loaded HTML.
 IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,
                        NavigateToDataURLWithBiDiControlChars) {
   // Text in Arabic.
   std::string text = "\xD8\xA7\xD8\xAE\xD8\xAA\xD8\xA8\xD8\xA7\xD8\xB1";
   // Page title starts with RTL mark.
@@ skipping 18 matching lines @@
   EXPECT_EQ(expected_title, params.target_contents->GetTitle());
   // GURL always keeps non-ASCII characters escaped, but check them anyways.
   EXPECT_EQ(GURL(expected_url).spec(), params.target_contents->GetURL().spec());
   // Check the omnibox text. It should have escaped RTL with unescaped text.
   LocationBar* location_bar = browser()->window()->GetLocationBar();
   OmniboxView* omnibox_view = location_bar->GetOmniboxView();
   EXPECT_EQ(base::UTF8ToUTF16(expected_url), omnibox_view->GetText());
 }
 
 }  // namespace