Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2030143002: Add FloatRegister names to RegisterConfiguration. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add FloatRegister names to RegisterConfiguration. - Adds names for float registers to RegisterConfiguration and uses them when we have the MachineRepresentation. LOG=N BUG=v8:4124 Committed: https://crrev.com/39442cf7143f8a4275dec8abf3457d948dbc4d55 Cr-Commit-Position: refs/heads/master@{#36712}

Patch Set 1 #

Patch Set 2 : Fix non-ARM ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -56 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M src/register-configuration.h View 3 chunks +5 lines, -0 lines 0 comments Download
M src/register-configuration.cc View 4 chunks +43 lines, -42 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bbudge
This should probably land before: https://codereview.chromium.org/2031873002/
4 years, 6 months ago (2016-06-02 23:42:53 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-03 04:37:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030143002/20001
4 years, 6 months ago (2016-06-03 12:59:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 13:01:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 13:02:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39442cf7143f8a4275dec8abf3457d948dbc4d55
Cr-Commit-Position: refs/heads/master@{#36712}

Powered by Google App Engine
This is Rietveld 408576698