Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2030133002: WebRTC: Move ensure_goma step to before runhooks step. (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Move ensure_goma step to before runhooks step. A similar fix was made for V8, see http://crbug.com/615351. BUG=615779 TBR=machenbach@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/ec406be638b956ef74ed6171e7e767f02445068a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2570 lines, -1976 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder__dbg_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_forced.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_mips__dbg_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86__dbg_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_clang__dbg_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn.json View 2 chunks +29 lines, -29 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gn__dbg_.json View 2 chunks +29 lines, -29 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced_invalid.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder__dbg_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder_x64__dbg_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_builder.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 2 chunks +55 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux32_arm.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__swarming_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_release__swarming_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__gn_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gn_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug__gn_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__gn_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__gn_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__gn_.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_clang_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_mips_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_dbg.json View 2 chunks +29 lines, -29 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_rel.json View 2 chunks +29 lines, -29 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 2 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_legacy_svn_patch.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_dbg.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_rel.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_swarming.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_dbg.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_swarming.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_full.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_light.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 2 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_dbg.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_rel.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030133002/1
4 years, 6 months ago (2016-06-02 18:22:16 UTC) #3
Michael Achenbach
lgtm
4 years, 6 months ago (2016-06-02 18:24:32 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 18:33:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/ec406be638b956ef74ed...

Powered by Google App Engine
This is Rietveld 408576698