scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json - Issue 2030133002: WebRTC: Move ensure_goma step to before runhooks step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json

Issue 2030133002: WebRTC: Move ensure_goma step to before runhooks step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json ('k') | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json

diff --git a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json

index dcfde80e5c0f4d0e01e05f515ee2f1808176d1f7..17135134e67ddf2f87461bf20e08890bf4d83053 100644

--- a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json

+++ b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json

@@ -76,21 +76,6 @@

"name": "cleanup_temp"

{

- "cmd": [

- "python",

- "-u",

- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",

- "runhooks"

- ],

- "cwd": "[SLAVE_BUILD]/src",

- "env": {

- "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

- "GYP_DEFINES": "clang=1 component=static_library dcheck_always_on=1 ffmpeg_branding=Chrome gomadir='[BUILD]/goma' release_extra_cflags=-fno-sanitize-recover=undefined rtc_use_h264=1 target_arch=x64 ubsan_vptr=1 use_goma=1",

- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

- },

- "name": "gclient runhooks"

- },

- {

"cmd": [],

"name": "ensure_goma"

@@ -145,6 +130,21 @@

]

{

+ "cmd": [

+ "python",

+ "-u",

+ "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",

+ "runhooks"

+ ],

+ "cwd": "[SLAVE_BUILD]/src",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

+ "GYP_DEFINES": "clang=1 component=static_library dcheck_always_on=1 ffmpeg_branding=Chrome gomadir='[CACHE]/cipd/goma' release_extra_cflags=-fno-sanitize-recover=undefined rtc_use_h264=1 target_arch=x64 ubsan_vptr=1 use_goma=1",

+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

+ },

+ "name": "gclient runhooks"

+ },

+ {

"allow_subannotations": true,

"cmd": [

"python",