scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json - Issue 2030133002: WebRTC: Move ensure_goma step to before runhooks step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json

Issue 2030133002: WebRTC: Move ensure_goma step to before runhooks step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json ('k') | scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json

diff --git a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json

index de5464f862f6291ec1acc5b86d8418858307f602..3b22387baee08d023c51eb5020ead3bbbcdc8858 100644

--- a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json

+++ b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json

@@ -93,34 +93,6 @@

"name": "clean isolated files"

{

- "cmd": [

- "python",

- "-u",

- "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",

- "runhooks"

- ],

- "cwd": "[SLAVE_BUILD]\\src",

- "env": {

- "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

- "GYP_DEFINES": "chromium_win_pch=0 component=shared_library dcheck_always_on=1 fastbuild=1 ffmpeg_branding=Chrome gomadir='[BUILD]\\goma' rtc_use_h264=1 target_arch=ia32 test_isolation_mode=prepare use_goma=1",

- "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"

- },

- "name": "gclient runhooks"

- },

- {

- "cmd": [

- "python",

- "-u",

- "[SLAVE_BUILD]\\src\\tools\\swarming_client\\swarming.py",

- "--version"

- ],

- "name": "swarming.py --version",

- "stdout": "/path/to/tmp/",

- "~followup_annotations": [

- "@@@STEP_TEXT@0.4.10@@@"

- ]

- },

- {

"cmd": [],

"name": "ensure_goma"

@@ -178,6 +150,34 @@

"cmd": [

"python",

"-u",

+ "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",

+ "runhooks"

+ ],

+ "cwd": "[SLAVE_BUILD]\\src",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

+ "GYP_DEFINES": "chromium_win_pch=0 component=shared_library dcheck_always_on=1 fastbuild=1 ffmpeg_branding=Chrome gomadir='[CACHE]\\cipd\\goma' rtc_use_h264=1 target_arch=ia32 test_isolation_mode=prepare use_goma=1",

+ "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"

+ },

+ "name": "gclient runhooks"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

+ "[SLAVE_BUILD]\\src\\tools\\swarming_client\\swarming.py",

+ "--version"

+ ],

+ "name": "swarming.py --version",

+ "stdout": "/path/to/tmp/",

+ "~followup_annotations": [

+ "@@@STEP_TEXT@0.4.10@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"RECIPE_PACKAGE_REPO[build]\\scripts\\tools\\runit.py",

"--show-path",

"python",