Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 2030133002: WebRTC: Move ensure_goma step to before runhooks step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 from recipe_engine import recipe_api 6 from recipe_engine import recipe_api
7 from . import builders 7 from . import builders
8 from . import steps 8 from . import steps
9 9
10 10
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 self.revision = revs['got_revision'] 139 self.revision = revs['got_revision']
140 self.revision_cp = revs['got_revision_cp'] 140 self.revision_cp = revs['got_revision_cp']
141 self.revision_number = str(self.m.commit_position.parse_revision( 141 self.revision_number = str(self.m.commit_position.parse_revision(
142 self.revision_cp)) 142 self.revision_cp))
143 143
144 def check_swarming_version(self): 144 def check_swarming_version(self):
145 if self.c.enable_swarming: 145 if self.c.enable_swarming:
146 self.m.swarming.check_client_version() 146 self.m.swarming.check_client_version()
147 147
148 def compile(self): 148 def compile(self):
149 self.m.chromium.ensure_goma()
150 compile_targets = self.recipe_config.get('compile_targets', []) 149 compile_targets = self.recipe_config.get('compile_targets', [])
151 self.m.chromium.compile(targets=compile_targets) 150 self.m.chromium.compile(targets=compile_targets)
152 151
153 def runtests(self): 152 def runtests(self):
154 """Add a suite of test steps. 153 """Add a suite of test steps.
155 154
156 Args: 155 Args:
157 test_suite: The name of the test suite. 156 test_suite: The name of the test suite.
158 """ 157 """
159 if self.c.use_isolate: 158 if self.c.use_isolate:
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 def clean_test_output(self): 281 def clean_test_output(self):
283 """Remove all test output in out/, since we have tests leaking files.""" 282 """Remove all test output in out/, since we have tests leaking files."""
284 out_dir = self.m.path['checkout'].join('out') 283 out_dir = self.m.path['checkout'].join('out')
285 self.m.python('clean test output files', 284 self.m.python('clean test output files',
286 script=self.resource('cleanup_files.py'), 285 script=self.resource('cleanup_files.py'),
287 args=[out_dir], 286 args=[out_dir],
288 infra_step=True) 287 infra_step=True)
289 288
290 def virtual_webcam_check(self): 289 def virtual_webcam_check(self):
291 self.m.python('webcam_check', self.resource('ensure_webcam_is_running.py')) 290 self.m.python('webcam_check', self.resource('ensure_webcam_is_running.py'))
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/standalone.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698