Replace elementHasLegalLinkAttribute() helper with virtual function

Replace elementHasLegalLinkAttribute() helper with virtual function

Replace elementHasLegalLinkAttribute() helper with virtual function on Element:
hasLegalLinkAttribute(). elementHasLegalLinkAttribute() was a bit complex due
to all the branching. Using a virtual function distributes the code to each
class and results in clearer code.

R=tkent, adamk

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169412

[Inactive, 2014-03-18 01:04:54]

Note the similarity with isURLAttribute() virtual function. I kept them separate
because they give slightly different results.

[tkent, 2014-03-18 01:23:30]

lgtm

https://codereview.chromium.org/202893002/diff/1/Source/core/html/HTMLInputEl...
File Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/202893002/diff/1/Source/core/html/HTMLInputEl...
Source/core/html/HTMLInputElement.cpp:1211: return (isImageButton() && name ==
srcAttr) || HTMLTextFormControlElement::hasLegalLinkAttribute(name);
We don't want to add new input-type check code in HTMLInputElement. We should
introduce InputType::hasLegalLinkAttribute, and ImageInputType should override
it.

FIXME comment or another CL is acceptable for this.

[Inactive, 2014-03-18 02:10:22]

https://codereview.chromium.org/202893002/diff/1/Source/core/html/HTMLInputEl...
File Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/202893002/diff/1/Source/core/html/HTMLInputEl...
Source/core/html/HTMLInputElement.cpp:1211: return (isImageButton() && name ==
srcAttr) || HTMLTextFormControlElement::hasLegalLinkAttribute(name);
On 2014/03/18 01:23:31, tkent wrote:
> We don't want to add new input-type check code in HTMLInputElement. We should
> introduce InputType::hasLegalLinkAttribute, and ImageInputType should override
> it.
> 
> FIXME comment or another CL is acceptable for this.

I added the InputType::hasLegalLinkAttribute() virtual function to this CL.
PTAL.

[tkent, 2014-03-18 02:11:36]

lgtm.
Thanks!

[tkent, 2014-03-18 02:12:08]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-18 03:19:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/202893002/20001

[commit-bot: I haz the power, 2014-03-18 04:26:10]

Change committed as 169412