Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 202893002: Replace elementHasLegalLinkAttribute() helper with virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/html/HTMLAnchorElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1032 matching lines...) Expand 10 before | Expand all | Expand 10 after
1043 // If there is currently no StyleResolver, we can't be sure that this attrib ute change won't affect style. 1043 // If there is currently no StyleResolver, we can't be sure that this attrib ute change won't affect style.
1044 shouldInvalidateStyle |= !styleResolver; 1044 shouldInvalidateStyle |= !styleResolver;
1045 1045
1046 if (shouldInvalidateStyle) 1046 if (shouldInvalidateStyle)
1047 setNeedsStyleRecalc(SubtreeStyleChange); 1047 setNeedsStyleRecalc(SubtreeStyleChange);
1048 1048
1049 if (AXObjectCache* cache = document().existingAXObjectCache()) 1049 if (AXObjectCache* cache = document().existingAXObjectCache())
1050 cache->handleAttributeChanged(name, this); 1050 cache->handleAttributeChanged(name, this);
1051 } 1051 }
1052 1052
1053 bool Element::hasLegalLinkAttribute(const QualifiedName&) const
1054 {
1055 return false;
1056 }
1057
1053 inline void Element::attributeChangedFromParserOrByCloning(const QualifiedName& name, const AtomicString& newValue, AttributeModificationReason reason) 1058 inline void Element::attributeChangedFromParserOrByCloning(const QualifiedName& name, const AtomicString& newValue, AttributeModificationReason reason)
1054 { 1059 {
1055 if (name == isAttr) 1060 if (name == isAttr)
1056 CustomElementRegistrationContext::setTypeExtension(this, newValue); 1061 CustomElementRegistrationContext::setTypeExtension(this, newValue);
1057 attributeChanged(name, newValue, reason); 1062 attributeChanged(name, newValue, reason);
1058 } 1063 }
1059 1064
1060 template <typename CharacterType> 1065 template <typename CharacterType>
1061 static inline bool classStringHasClassName(const CharacterType* characters, unsi gned length) 1066 static inline bool classStringHasClassName(const CharacterType* characters, unsi gned length)
1062 { 1067 {
(...skipping 2477 matching lines...) Expand 10 before | Expand all | Expand 10 after
3540 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3545 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3541 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3546 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3542 if (isHTMLOptionElement(*this) || isHTMLOptGroupElement(*this)) 3547 if (isHTMLOptionElement(*this) || isHTMLOptGroupElement(*this))
3543 return false; 3548 return false;
3544 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3549 if (FullscreenElementStack::isActiveFullScreenElement(this))
3545 return false; 3550 return false;
3546 return true; 3551 return true;
3547 } 3552 }
3548 3553
3549 } // namespace WebCore 3554 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/html/HTMLAnchorElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698