Source/web/WebPageSerializerImpl.cpp - Issue 202893002: Replace elementHasLegalLinkAttribute() helper with virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPageSerializerImpl.cpp

Issue 202893002: Replace elementHasLegalLinkAttribute() helper with virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPageSerializerImpl.cpp

diff --git a/Source/web/WebPageSerializerImpl.cpp b/Source/web/WebPageSerializerImpl.cpp

index 68b0e9d79e00037a713523e566250e63297458bc..b4787c233ef13703146bd1d3e0d98f1fa66dd469 100644

--- a/Source/web/WebPageSerializerImpl.cpp

+++ b/Source/web/WebPageSerializerImpl.cpp

@@ -78,7 +78,6 @@

#include "config.h"

#include "WebPageSerializerImpl.h"

-#include "DOMUtilitiesPrivate.h"

#include "HTMLNames.h"

#include "WebFrameImpl.h"

#include "core/dom/Document.h"

@@ -317,7 +316,7 @@ void WebPageSerializerImpl::openTagToString(Element* element,

// Check whether we need to replace some resource links

// with local resource paths.

const QualifiedName& attrName = attribute.name();

- if (elementHasLegalLinkAttribute(element, attrName)) {

+ if (element->hasLegalLinkAttribute(attrName)) {

// For links start with "javascript:", we do not change it.

if (attrValue.startsWith("javascript:", false))

result.append(attrValue);

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebPasswordFormData.cpp » ('j') | no next file with comments »