Source/core/html/HTMLObjectElement.cpp - Issue 202893002: Replace elementHasLegalLinkAttribute() helper with virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 202893002: Replace elementHasLegalLinkAttribute() helper with virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLObjectElement.cpp

diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp

index 5e0fb91eb85a043537f3ec574a8915ffcf587089..4c81b74b9a6640bf7a4dbd297692417458573d4c 100644

--- a/Source/core/html/HTMLObjectElement.cpp

+++ b/Source/core/html/HTMLObjectElement.cpp

@@ -370,6 +370,11 @@ bool HTMLObjectElement::isURLAttribute(const Attribute& attribute) const

|| HTMLPlugInElement::isURLAttribute(attribute);

}

+bool HTMLObjectElement::hasLegalLinkAttribute(const QualifiedName& name) const

+ return name == classidAttr || name == dataAttr || name == codebaseAttr || HTMLPlugInElement::hasLegalLinkAttribute(name);

const AtomicString HTMLObjectElement::imageSourceURL() const

{

return getAttribute(dataAttr);

« no previous file with comments | « Source/core/html/HTMLObjectElement.h ('k') | Source/core/html/HTMLQuoteElement.h » ('j') | no next file with comments »